tickets

4.2 KB

1. # Report 012 (w091): tickets#25 API part — a project by its id
3. **Where:** one commit on main in loreana:/media/STORAGE/projects/tickets.worldapi.org (on top of 7538b03).
4. Not pushed, not deployed. No `.env` read. Ports used: 8760–8764 and 8767–8769 (8765/8766 not touched). Every server I
5. started was stopped by its PID; nothing of mine is still running (checked with `ss -ltn` and `ps … hl-browser-tier`).
7. ## What changed
8. - **Every `/api/projects/<x>/…` route takes the slug OR the project's id** (all 16 routes: the project itself, members,
9. members/remove, invites, connections, connections/remove, tickets, tickets/<n> and its comments / state / edit / assign /
10. parent / blocked-by). GET and POST.
11. - **The id format:** projects had no short id, so it is the existing record id: hl:mpackdb's `@id`, **12 characters
12. `[0-9a-z]`** (time-based), e.g. `0mufbw18nsuj` = tickets.worldapi.org. Shown as `id` in `GET /api/projects` (`details`)
13. and `GET /api/projects/<x>` (`project`). It stays the same when the slug changes (checked in the gate).
14. - **Tickets stay under their project:** `/api/projects/<id or slug>/tickets/<n>`. **No new global `/api/tickets/<x>`.**
15. The old `/api/tickets/<old number | ticket UUID>` is unchanged; `/api/tickets/<project id>` → 404 as before.
16. - **How:** `lib/projects.hl slugOfRef` — a slug (also an old one) stays as it is; else a project id gives its CURRENT slug;
17. else unchanged (names nothing → 404 as before). `lib/api.hl slugOf(route)` uses it in `byNumber` and in the 7 route
18. functions that read `route.params.slug`. Everything after that runs as with the slug, so the id form answers byte for
19. byte what the slug form answers. A slug is tried first: it would win if a slug ever equalled another project's id.
20. - **Not changed:** pages (`/<slug>`, `/projects/<slug>` … take slugs only), every existing API path and answer.
22. ## Tests
23. | test | result |
24. |---|---|
25. | gate `tests/browser.mjs` (`.scratch/w091/gate.sh`) | **315 passed, 0 failed** (293 before + 22 new "ids (#25)") |
26. | control: the same gate on the OLD code (`.scratch/w091/old`) | 286 passed, **13 failed — exactly the id checks**, then it stops |
27. | `tests/connect.mjs` (`.scratch/w091/connect.sh`) | **60 passed, 0 failed**, twice. A first run stopped once at "#connecttitleinput" (the connect page's UI, not touched) — a flake |
28. | real-data copy, new `tests/projectids-realdata.py` (old :8763 vs new :8764) | **0 FAILED** (see below) |
29. | `tests/letcount.py` | never-reassigned `let` = 0 |
31. **The new gate checks:**
32. - 9 reads by id equal the slug form byte for byte: the project, its tickets (+ `?state=open`, `?state=bogus`, Markdown), ticket 1
33. (JSON + Markdown), a missing ticket, the connections.
34. - An unknown id → 404 on 4 routes.
35. - `/api/tickets/<project id>` → 404.
36. - Every write route by id:
37. - a new project `delta`: POST tickets → 201 #1;
38. - comments, state, edit, assign, parent, blocked-by → 201 each, and the slug form reads what they wrote;
39. - the project POST, members, members/remove → 200;
40. - invites with a bad role and connections/remove of an unknown key → 400 (the project's own checks, not 404);
41. - POST to an unknown id → refused.
42. - After a slug change, the id, the new slug and the old slug answer the same ticket.
43. - The PWA count is now TOTAL + 1, because of the ticket made by id.
45. **Real-data copy:** taken from Byrodin on 2026-10-04 around 05:00 and deleted after the run.
46. - **Data:** 11 projects, 309 tickets.
47. - **Old vs new code, 1,484 answers:** every API read as JSON and as Markdown, and the refusals. All byte-identical, including status and content type.
48. - **On the new code, 772 slug-vs-id answers:** every project route, plus every ticket by id, as JSON and as Markdown. All identical.
49. - **404s:** an unknown id, and `/api/tickets/<project id>` for all 11 projects.
50. - **The ticket's own case:** `/api/projects/0mufbw18nsuj/tickets/25` returns the Markdown of tickets.worldapi.org #25. The old code returns 404 for `/api/projects/0mufbw18nsuj`.
52. ## Not done / open
53. - **Not deployed:** deploying is the architect's job (`./deploy.sh`). There is no data change.
54. - **Tools:** t.py, watch.py and the connected apps keep working unchanged. They can switch to ids whenever that is wanted.
55. - **Scratch (gitignored) in `.scratch/w091/`:** `gate.sh`, `connect.sh`, the gate logs and the old tree.